Be able to add negative values in the manual splitting

ecmwf / ecpoint-calibrate

Interactive GUI (developed in Python) for calibration and conditional verification of numerical weather prediction model outputs.

GNU General Public License v3.0

21 stars 8 forks source link

Be able to add negative values in the manual splitting #140

Closed EstiGascon closed 3 years ago

EstiGascon commented 3 years ago

When we use the tool of splitting a predictor with breakpoints manually (instead of using the Kolmogorov test), currently we are not allowed to introduce negative values (see attachment). However, we will need this capability because many predictors contain negative values as well. Splitting_tool

ATimHewson commented 3 years ago

This seems like a bug to me, that should be assigned top priority, but up to you Esti how you classify (based on how restrictive it is for you).

EstiGascon commented 3 years ago

Thanks Tim. Yes, I put it like a bug at the beginning, but as we had worked until now with that...I changed to enhancement. After yesterday´s conversation and the questions about the Kolmorov test, yes, this probably should be a bug, as we need to use it more frequently

FatimaPillosu commented 3 years ago

Now there is no due date for bugs, as they will continue to appear through the whole project. So, please, feel free to keep adding issue with the "Bug" label if needed. This is not indeed an enhancement, as it has to be corrected. Enhancements are for things that are working and could be further improved. I'm sure @onyb will be able to correct it soon.

onyb commented 3 years ago

Fixed in v0.18.0.