ecmwf / ecpoint-calibrate

Interactive GUI (developed in Python) for calibration and conditional verification of numerical weather prediction model outputs.
GNU General Public License v3.0
21 stars 8 forks source link

Leakage of variables #158

Closed AugustinVintzileos closed 3 years ago

AugustinVintzileos commented 3 years ago

I am loosing variables when I try to select one for the KS-test. This happens after a few cycles of growing and pruning branches. Example. For the tree:

image

When I try to do a KS-test at the SKT level I am getting:

image

from where a lot of variables are missing e.g., FAL, LCC, and CAPE

My intuition is that it is happening when collapsing branches for testing new variables.

EstiGascon commented 3 years ago

We had a meeting this afternoon to discuss this issue, and we found out something which could affect (not sure how much, but it is a bug, fur sure). Let's explain it with the following plot Bug_tree

The final weather type names are OK. However, if you see the Root weather type or the different weather types in the 2 LSM branches, they are incorrect as well. For example, the root WT is here 2010000000, when it should be just 0000000000, with any digit different to zero.

FatimaPillosu commented 3 years ago

Hi @onyb I spoke yesterday with Augustin and we realized that this was a user error. We know now what is causing it, so I will close this issue. Cheers, Fatima