Error when plotting the mapping function for a circular variable

ecmwf / ecpoint-calibrate

Interactive GUI (developed in Python) for calibration and conditional verification of numerical weather prediction model outputs.

GNU General Public License v3.0

20 stars 8 forks source link

Error when plotting the mapping function for a circular variable #165

Closed FatimaPillosu closed 3 years ago

FatimaPillosu commented 3 years ago

When a circular variable is not a leaf or there is no selection of breakpoints for that variable, there is an error when displaying the mapping function. It selects the same value for the thr_L and thr_H. Clearly, there won't be any plot because no points will satisfy this condition. In this case, even for circular variables, we should have (-inf<=LST<inf).

onyb commented 3 years ago

With the recent changes (probably as of last release), I believe this shouldn't be an issue anymore. Can you please try again?

Here's the mapping function for the same dataset and breakpoints as in the description:

WT_10

I found a bug in circular breakpoints validation that prevented us from having the default range as the breakpoints. This is fixed, and will be available in the next release:

onyb commented 3 years ago

Should be fixed as of v0.28.0. Please reopen if this is not the case.