search

ecmwf / fckit

A Fortran toolkit for interoperating Fortran with C/C++
https://confluence.ecmwf.int/display/fckit
Apache License 2.0
29 stars 13 forks source link

Make fypp install/export optional #35

Closed awnawab closed 4 months ago

awnawab commented 4 months ago

Currently, fckit will override any local fypp if it is included in a bundle. This can be problematic if a project in that bundle needs a newer version of fypp. This PR changes the default behaviour so that fypp is only installed and exported by fckit if it is not already found. Could you please tag a release once this PR is approved and merged? I would like to include it in an updated ifs-bundle.

FussyDuck commented 4 months ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.07%. Comparing base (a92be06) to head (f49879d). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #35 +/- ## ======================================== Coverage 52.07% 52.07% ======================================== Files 52 52 Lines 4388 4388 ======================================== Hits 2285 2285 Misses 2103 2103 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wdeconinck commented 4 months ago

This currently fails the downstream-ci: 

/usr/bin/python3.9: can't open file '/opt/actions-runner/work/_work/_temp/install/fckit/libexec/fckit-fypp.py': 
[Errno 2] No such file or directory
wdeconinck commented 4 months ago

@awnawab version 0.11.1 contains this change.