Improve robustness of xarray interface

ecmwf / magics-python

Python interface to Magics meteorological plotting package

Apache License 2.0

49 stars 12 forks source link

Improve robustness of xarray interface #13

Closed dtip closed 5 years ago

dtip commented 5 years ago

The magics-cxx xarray code is now on conda-forge so the CI ought to pass. We'll see.

FussyDuck commented 5 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: sylvielamythepaut
:white_check_mark: dtip
:x: StephanSiemen
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

dtip commented 5 years ago

Looks like the new code works. The only failing test on all platforms is test_projection5 which is failing due to Magics incompatibility issues with Proj4 v6.

I'll leave this PR open. An admin can decide whether to merge it with the test still failing (probably the best way forward to ensure this code doesn't go stale) or to wait until Magics is full compatible with Proj4 v6.

sylvielamythepaut commented 5 years ago

Merging .. keeping in mind that One test will fail when using latest version of proj4