Enable Windows build with Proj4 v6

ecmwf / magics

Plotting package to visualise meteorological data in GRIB, NetCDF, BUFR and ODB format.

Apache License 2.0

56 stars 15 forks source link

Enable Windows build with Proj4 v6 #15

Closed dtip closed 5 years ago

dtip commented 5 years ago

There were a couple of patches which I needed to add to get the magics-feedstock to build on Windows (see https://github.com/conda-forge/magics-feedstock/pull/35). One is already merged into ecBuild.

This PR defines PROJ_MSVC_DLL_IMPORT so we can import proj_api.h without getting 'unresolved external symbol' errors.

We also update the CI to build with proj4 v6.

dtip commented 5 years ago

Ah, the tests for this PR are going to fail because the develop branch is currently broken :(

dtip commented 5 years ago

Looks like Magics isn't yet ready for proj4 v6 - some of the tests fail. The first two commits have been merged in https://github.com/ecmwf/magics/pull/16 so I'll close this.