ecmwf / pdbufr

High-level BUFR interface for ecCodes
Apache License 2.0
23 stars 8 forks source link

Simplify code for checking if a key is a coordinate #59

Closed sandorkertesz closed 1 year ago

sandorkertesz commented 1 year ago

The aim of this PR is to simplify the code that checks if a BUFR key is a coordinate descriptor. The performance optimisation related to #54 should not be affected.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 86.36% and project coverage change: -0.35 :warning:

Comparison is base (9283682) 95.14% compared to head (a63c48e) 94.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #59 +/- ## ========================================== - Coverage 95.14% 94.79% -0.35% ========================================== Files 15 15 Lines 1626 1652 +26 Branches 212 216 +4 ========================================== + Hits 1547 1566 +19 - Misses 61 66 +5 - Partials 18 20 +2 ``` | [Impacted Files](https://app.codecov.io/gh/ecmwf/pdbufr/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf) | Coverage Δ | | |---|---|---| | [pdbufr/bufr\_structure.py](https://app.codecov.io/gh/ecmwf/pdbufr/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-cGRidWZyL2J1ZnJfc3RydWN0dXJlLnB5) | `92.09% <83.01%> (-1.58%)` | :arrow_down: | | [pdbufr/high\_level\_bufr/bufr.py](https://app.codecov.io/gh/ecmwf/pdbufr/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-cGRidWZyL2hpZ2hfbGV2ZWxfYnVmci9idWZyLnB5) | `87.17% <100.00%> (+1.76%)` | :arrow_up: | | [tests/test\_20\_bufr\_structure.py](https://app.codecov.io/gh/ecmwf/pdbufr/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-dGVzdHMvdGVzdF8yMF9idWZyX3N0cnVjdHVyZS5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.