search

ecmwf / pyflow

A high level Python interface to ecFlow allowing the creation of ecFlow suites in a modular and "pythonic" way
https://pyflow-workflow-generator.readthedocs.io/en/latest/
Apache License 2.0
7 stars 7 forks source link

WIP: Hotfix/file_resource_script_generation #46

Open tbkr opened 2 months ago

tbkr commented 2 months ago

When working with marsflow I encountered problems with the pf.FileResource class which was mainly due to the reason that the internals of the resource class have changed.

I enabled moved the assignment of the server_filename to the constructor of the pf.FileResource class and adjusted other occurrences.

In case my changes broke the intended architecture, feel free to comment.

FussyDuck commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

corentincarton commented 2 months ago

@tbkr, thanks for this contribution! I never really used the resource feature of pyflow. Could you just add a test for the Resource class?

tbkr commented 2 months ago

@corentincarton I added a test case for the resource file creation and also for the use case of deploying it to several hosts.

Could you have a look?