search

ecn310 / course-project-accidentsteam

course-project-accidentsteam created by GitHub Classroom
0 stars 0 forks source link

Feedback #1

Open github-classroom[bot] opened 1 year ago

github-classroom[bot] commented 1 year ago

:wave:! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher. In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens. Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.

Subscribed: @wmwaghor @Tomoyoshikun @Yuhan-2435 @annarupert

kbuzard commented 1 year ago

@ecn310/accidentsteam On the lit review: You have chosen what look like very useful papers, and there are indications of potentially useful theories in most if not all of them. However, most of what you've included so far in the document is very general; the theories have to be made more specific for this to be helpful in hypothesis formulation.

This assignment could score 3/5 at best because for 4 or above, you needed to respond to "most" comments, and I only see a response to three (Anna responded to both comments on her section; Will responded to one out of three comments on his) out of all the comments I gave you.