ecn310 / course-project-international-trade-policy

course-project-international-trade-policy created by GitHub Classroom
0 stars 0 forks source link

Feedback #1

Closed github-classroom[bot] closed 6 months ago

github-classroom[bot] commented 9 months ago

:wave:! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher. In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens. Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.

Subscribed: @aryar5 @SawyerMcFarland @lefaulk

annarupert commented 6 months ago

Hi! I am doing feedback for some of the groups for extra credit, I think you guys did a great job on the shorter read me overall. I noticed that it does not have your groups contact information, I do not think this is a must have but it helps anyone who is reproducing the material understand who was apart of this research. Prof. Buzard recommended that to my group to do as well.