search

eco-stake / restake

Auto-compounder script for Cosmos Validators using REStake
https://restake.app
MIT License
359 stars 311 forks source link

restake Pro (withdraw commission) #49

Open joeabbey opened 2 years ago

joeabbey commented 2 years ago

Mebbe add an optional Pro mode where a validator can grant restake

/cosmos.distribution.v1beta1.MsgWithdrawValidatorCommission

and then autostake can issue those....

tombeynon commented 2 years ago

Love it. autostaking script can adapt depending on the granted permissions. Definitely need a modal for grant to let user customise expiry, max tokens, and additional features like this.

So it's clear to everyone else; Restake doesn't have a database and everything is driven around the grants existing on-chain

blacklodge-admin commented 1 year ago

Love it. autostaking script can adapt depending on the granted permissions. Definitely need a modal for grant to let user customise expiry, max tokens, and additional features like this.

So it's clear to everyone else; Restake doesn't have a database and everything is driven around the grants existing on-chain

Hi @tombeynon! Thank you so much for the invaluable tool that is restake.

What exactly is still needed here as far as the autostaking logic is concerned? Are you open to outside contributions here, and – if so – do you have a rough design in mind? I've stepped through the code here a handful of times and am tempted to take a stab at it in my own fork, but figured I'd check in first.

tombeynon commented 1 year ago

Hey @blacklodge-admin! Thanks for the nice comments, I'm taking a month out to get on top of some admin but will be back up to speed with REStake soon.

In terms of this feature - I think it's safe to assume that if a validator has granted WithdrawCommission and WithdrawRewards permissions to their REStake address, the script can recognise this and autocompound their commission as well. The REStake UI makes it easy to grant these permissions now so we don't need to update the UI immediately.

It's pretty trivial to add a check to the script to look for these permissions and send an extra message if they exist, although the code needs a bit of love in general to make it easier to maintain. If you're interested in taking a stab I'd be very happy to help out, otherwise it might need to wait a month for me to investigate it further. You can find me on Discord or we can discuss it further here.

davidquarles commented 1 year ago

Hey @blacklodge-admin! Thanks for the nice comments, I'm taking a month out to get on top of some admin but will be back up to speed with REStake soon.

In terms of this feature - I think it's safe to assume that if a validator has granted WithdrawCommission and WithdrawRewards permissions to their REStake address, the script can recognise this and autocompound their commission as well. The REStake UI makes it easy to grant these permissions now so we don't need to update the UI immediately.

It's pretty trivial to add a check to the script to look for these permissions and send an extra message if they exist, although the code needs a bit of love in general to make it easier to maintain. If you're interested in taking a stab I'd be very happy to help out, otherwise it might need to wait a month for me to investigate it further. You can find me on Discord or we can discuss it further here.

Awesome, I'll give it a try in the next couple days then!