ecoacoustics / web-components

https://oe-web-components.netlify.app/

MIT License

1 stars 0 forks source link

Fix: Rows with no decisions should be emitted #101

Closed hudson-newey closed 3 months ago

hudson-newey commented 3 months ago

Fix: Rows with no decisions should be emitted

A short description of the pull request

Changes

Features

None

Bug Fixes

Rows with no decisions are now emitted in downloaded results
Fixes a bug where the first page of a verification grid would really be the second
Fixes a bug where if there was a decision button without a shortcut, the help dialog would fail to open
Fixes a bug where the download results button would not should if the local attribute was not present

Code Quality

None

Related Issues

Fixes: #95

Final Checklist

[x] All commits messages are semver compliant
[x] Added relevant unit tests for new functionality
[x] Updated existing unit tests to reflect changes
[x] Code style is consistent with the project guidelines
[ ] Documentation is updated to reflect the changes (if applicable)
[x] Link issues related to the PR
[x] Assign labels if you have permission
[ ] Assign reviewers if you have permission
[ ] Ensure that CI is passing
[x] Ensure that pnpm lint runs without any errors
[ ] Ensure that pnpm test runs without any errors

github-actions[bot] commented 3 months ago

🚀 Deployed on https://66a1cfda27d6849c8362f8ea--oe-web-components.netlify.app