ecoacoustics / web-components

https://oe-web-components.netlify.app/

MIT License

1 stars 0 forks source link

New verification/classification mental models #104

Closed hudson-newey closed 3 months ago

hudson-newey commented 3 months ago

New verification/classification mental models

Changes

Features

Adds support for classification use cases
Refactor the getPage to support iterator functions through context objects
Adds tag recognition for "scientificName" and "commonName" column names
Adds support for space separated column keys such as "common name"

Bug Fixes

Fixed bug where the info card would not display the "show more" button when subjects had more than 3 key-value pairs
Makes the play/pause buttons $1.5 \times$ larger (so that it appears to be the same size as the rest of the media control icons)
Fixes bug where colorBrewer was using a linear gradient (not categorical)
Fixes bug where multiple additional tags would not be separated by a comma

Code Quality

Add internal documentation about documented use cases
Now uses the theme colors for the the verification grid tile hover effect (was previously a constant)
- I also reduced the --oe-backdrop-shadow by 33% (this was only ever used in the grid tile component)
queryAllDeeplyAssignedElements now returns an empty array if no elements match the selector
Moved Annotation, Decision, Verification, and Classification class models into their own separate files (they were previously all in the one file)
Generated snapshot tests
Runs prettier over the code base to fix inconsistent indentation

Remaining Bugs / Unresolved Problems

Visual Changes

New classification use cases

Old & new icon sizes for the media controls play/pause button

Old & new drop shadow for hovering over a tile

Documentation Examples

Related Issues

Fixes: #68

Additional Notes

Final Checklist

[ ] All commits messages are semver compliant
[ ] Added relevant unit tests for new functionality
[x] Updated existing unit tests to reflect changes
[x] Code style is consistent with the project guidelines
[ ] Documentation is updated to reflect the changes (if applicable)
[x] Link issues related to the PR
[x] Assign labels if you have permission
[x] Assign reviewers if you have permission
[x] Ensure that CI is passing
[x] Ensure that pnpm lint runs without any errors
[x] Ensure that pnpm test runs without any errors

github-actions[bot] commented 3 months ago

🚀 Deployed on https://66b2fb41abac605c7dd1d380--oe-web-components.netlify.app

hudson-newey commented 3 months ago

Additional comments from user testing:

~The "Continue Verifying" should be "Continue Classifying" during a classification only task~ (resolved)