This pull request adds an oe-settings component which (currently) contains a fullscreen button.
The hope is to extend this component in the future to change settings about the verification grid.
I have not finished the tests yet, but the fullscreen component is complete, and I have outlined all the tests that I want to implement
Changes
Features
Adds a fullscreen through an oe-verification-grid-settings component that allows the user to fullscreen the verification grid component
Adds a message to the help dialog that we recommend using the verification grid in fullscreen mode
Bug Fixes
Fixes a bug where verification grid shortcut keys would not work when sub-selection was disabled (e.g. for a single item grid)
Code Quality
Fixes bug in the VSCode workspace which caused inconsistent formatters to run
The oe-data-source now checks that the target of the for attribute is an oe-verification-grid
Toggling the oe-help-dialog now listens for a click event (which emits a PointerEvent event model). This adds support for toggling the help dialog through tab-stops and improves accessibility
Modifies the previously unused @queryParentElement decorator so that it can pierce shadow DOM
Stop prettier from scanning config files & build artifacts (improving performance, and reducing bugs)
Remaining Bugs / Unresolved Problems
Visual Changes
A verification grid with the new fullscreen button. Note: The position is configurable and this is not the position in all verification grids
Documentation Examples
Related Issues
Fixes: #130
Additional Notes
I am using sl-tooltip for the fullscreen buttons tooltip.
This PR therefore adds sl-tooltip as a dependency
Final Checklist
[x] All commits messages are semver compliant
[x] Added relevant unit tests for new functionality
[x] Updated existing unit tests to reflect changes
[x] Code style is consistent with the project guidelines
[ ] Documentation is updated to reflect the changes (if applicable)
Add fullscreen toggle button
This pull request adds an
oe-settings
component which (currently) contains a fullscreen button.The hope is to extend this component in the future to change settings about the verification grid.
I have not finished the tests yet, but the fullscreen component is complete, and I have outlined all the tests that I want to implement
Changes
Features
oe-verification-grid-settings
component that allows the user to fullscreen the verification grid componentBug Fixes
Code Quality
oe-data-source
now checks that the target of thefor
attribute is anoe-verification-grid
oe-help-dialog
now listens for aclick
event (which emits aPointerEvent
event model). This adds support for toggling the help dialog through tab-stops and improves accessibility@queryParentElement
decorator so that it can pierce shadow DOMRemaining Bugs / Unresolved Problems
Visual Changes
A verification grid with the new fullscreen button. Note: The position is configurable and this is not the position in all verification grids
Documentation Examples
Related Issues
Fixes: #130
Additional Notes
I am using
sl-tooltip
for the fullscreen buttons tooltip. This PR therefore addssl-tooltip
as a dependencyFinal Checklist
pnpm lint
runs without any errorspnpm test
runs without any errors