Move grid template into verification grid component
This pull request provides a default template for the verification grid tiles which includes the axes, indicator, and media controls component.
Changes
Features
Adopts a common template for the verification grid tiles
Bug Fixes
Fixes a bug where the doc pages would show "No decisions found"
Fixes leaky tests in verification-grid.e2e.spec.ts that were caused by some async assertions not being awaited
Weak version matching for playwright created situations where two different versions of Playwright could be installed (resulting in CI failing to run). To fix this, Playwright versions have been locked (required pnpm-lock.json regeneration)
Code Quality
Virtual paging now uses Lit's optimized repeat directive (this was "nessecary" for this PR as it significantly improves use of signals)
Removes render-invalidation from the verification grid component, meaning that we always use virtual paging, and will never destroy/recreate verification grid tiles (this change was nessecary so that signal lifetimes can be conseptulized easier)
Fix missing awaits that should have been prevent on the renderVirtualPage method
The verification grid's fullscreen state is now stored in a settings object signal
Disabled the no-complex-attribute-binding rule in lit-analyzer
Remaining Bugs / Unresolved Problems
Visual Changes
N.A.
Related Issues
Fixes: #115
Fixes: #149 (had to complete to get signals to working correctly)
Additional Notes
This PR increases the size of the kaleidoscope mock dataset to allow the testing of a 20 tile grid
Final Checklist
[x] All commits messages are semver compliant
[x] Added relevant unit tests for new functionality
[x] Updated existing unit tests to reflect changes
[x] Code style is consistent with the project guidelines
[x] Documentation is updated to reflect the changes (if applicable)
Move grid template into verification grid component
This pull request provides a default template for the verification grid tiles which includes the axes, indicator, and media controls component.
Changes
Features
Bug Fixes
verification-grid.e2e.spec.ts
that were caused by some async assertions not being awaitedCode Quality
repeat
directive (this was "nessecary" for this PR as it significantly improves use of signals)renderVirtualPage
methodno-complex-attribute-binding
rule inlit-analyzer
Remaining Bugs / Unresolved Problems
Visual Changes
N.A.
Related Issues
Fixes: #115 Fixes: #149 (had to complete to get signals to working correctly)
Additional Notes
This PR increases the size of the
kaleidoscope
mock dataset to allow the testing of a 20 tile gridFinal Checklist
pnpm lint
runs without any errorspnpm test
runs without any errors