search

ecoacoustics / web-components

https://oe-web-components.netlify.app/
MIT License
1 stars 0 forks source link

Exit Fullscreen Icon Missing #171

Closed nellihol closed 2 months ago

nellihol commented 2 months ago

Describe the bug

Full screen mode icon disappears when in full screen mode. There should be an icon indicating exit full screen mode.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Multiple Verification Grid'
  2. Click on 'Full Screen' button
  3. See error: No Exit Full Screen icon on the button

Expected behavior

Expecting an icon similar to this: 1126 (Arrows pointing to middle)

Screenshots

image

hudson-newey commented 2 months ago

Fixed in https://github.com/ecoacoustics/web-components/pull/161

This was caused by an additional space after the sl-icon name

https://github.com/ecoacoustics/web-components/blob/262d397dd1713d50cdf2c441ee8b10a7c49392a1/src/components/verification-grid-settings/verification-grid-settings.ts#L138

In the future we do some fancy TypeScript typing to catch these errors in the CI