search

ecocurious2 / MultiGeiger

Geigerzähler mit ESP32 und empfindlichem Si22g-Zählrohr (Gamma)
https://multigeiger.readthedocs.io/
GNU General Public License v3.0
71 stars 30 forks source link

not calling wait_ntp (yet)? #429

Closed ThomasWaldmann closed 3 years ago

ThomasWaldmann commented 3 years ago

there's an implementation, but we are not calling it.

ThomasWaldmann commented 3 years ago

https://github.com/ecocurious2/MultiGeiger/issues/410#issuecomment-841680073

as seen there: it can take > 20s for NTP to establish the correct time (if a network connection can be established, which is not necessarily always the case, the MultiGeiger could be without WiFi, just using LoRa or BT).

currently, we just live with the wrong time until NTP has worked.

the alternative would be blocking (by calling wait_ntp) until we have the correct time.

ThomasWaldmann commented 3 years ago

decision from meeting: we do not want to block waiting for ntp, so the wait_ntp code is not needed and can be removed.