Codecov Report

Merging #122 (6e39929) into dev (8fe30c3) will decrease coverage by 1.00%. The diff coverage is 77.85%.

:exclamation: Current head 6e39929 differs from pull request most recent head b862675. Consider uploading reports for the commit b862675 to get more accurate results

@@            Coverage Diff             @@
##              dev     #122      +/-   ##
==========================================
- Coverage   83.97%   82.96%   -1.01%     
==========================================
  Files          22       23       +1     
  Lines        1373     1644     +271     
==========================================
+ Hits         1153     1364     +211     
- Misses        189      237      +48     
- Partials       31       43      +12

Impacted Files	Coverage Δ
internal/model/model.go	`87.61% <0.00%> (-2.58%)`	:arrow_down:
internal/test/types.go	`27.27% <ø> (ø)`
builder.go	`75.79% <45.23%> (-7.26%)`	:arrow_down:
select.go	`85.07% <76.00%> (-4.83%)`	:arrow_down:
table.go	`93.16% <93.16%> (ø)`
aggregate.go	`96.38% <100.00%> (+0.04%)`	:arrow_up:
column.go	`89.28% <100.00%> (+0.09%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

liangzai202204 commented 1 year ago

集成测试\internal\integration\ select_test.go,TestMySQL8SelectJoin

liangzai202204 commented 1 year ago

mysql初始化.\script\mysql\init.sql新增建表语句

flycash commented 1 year ago

check license 失败，说明你有一些新文件没有加上我们的 license 说明
format go code，记得调用 make check, 或者自己调用 goimports 来格式化代码
changelog，就是把这个合并请求加进去我们的 .CHANGELOG 里面的 develop 下面
deepsource，应该就是各种静态代码检查的问题，你需要进去看看。有些你觉得没必要修的，可以留言
codecov，这个可能是统计不准，你 rebase 一下最新的 gotomicro/eorm 的 dev 分支。（rebase 各种冲突的话，你合并一下也可以）

flycash commented 1 year ago

我先合并了，我自己动手微调一下

ecodeclub / eorm

join查询 #122

Codecov Report