Closed Stone-afk closed 1 year ago
Merging #181 (df53a2f) into dev (3fae3b6) will increase coverage by
2.31%
. The diff coverage is88.46%
.
@@ Coverage Diff @@
## dev #181 +/- ##
==========================================
+ Coverage 82.55% 84.86% +2.31%
==========================================
Files 36 36
Lines 2705 2723 +18
==========================================
+ Hits 2233 2311 +78
+ Misses 388 335 -53
+ Partials 84 77 -7
Impacted Files | Coverage Δ | |
---|---|---|
expression.go | 82.35% <ø> (ø) |
|
predicate.go | 92.00% <ø> (ø) |
|
sharding_select.go | 73.85% <88.00%> (+19.60%) |
:arrow_up: |
builder.go | 85.96% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
先挂起,等你的 Datasource 合并进去再说
一般来说,error 分支都是要覆盖到的,除非实在是没办法。覆盖 error 分支很重要的一个点是确保程序如预期返回 error 了,也就是把行为固化下来;一方面也是为了确切验证,error 不仅返回了,还是我们预期的那个 error。比如说之前我们就遇到过,虽然都返回了 error,但是 error 其实是另外一个 error,引起的线上故障。
单元测试正在补