search

ecodeclub / eorm

简单 ORM 框架
Apache License 2.0
194 stars 64 forks source link

Rft: remove NilAsNullFunc #48

Closed flycash closed 2 years ago

flycash commented 2 years ago

I think NilAsNullFunc is not a good abstraction. So I introduce two concepts:

  1. zero value
  2. nil value

But zero value is not the same as reflect.IsZero because the zero value in EQL doesn't contain nil value

codecov[bot] commented 2 years ago

Codecov Report

Merging #48 (c09c9ee) into main (665cf67) will increase coverage by 0.82%. The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   79.61%   80.43%   +0.82%     
==========================================
  Files          14       14              
  Lines         721      695      -26     
==========================================
- Hits          574      559      -15     
+ Misses        129      117      -12     
- Partials       18       19       +1
Impacted Files Coverage Δ
db.go 90.90% <ø> (+6.49%) :arrow_up:
update.go 88.98% <89.65%> (+3.98%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 665cf67...c09c9ee. Read the comment docs.