search

ecohealthalliance / doltr

A client for dolt databases
https://ecohealthalliance.github.io/doltr
GNU Affero General Public License v3.0
17 stars 2 forks source link

Hotfix/as of bug #66

Closed n8layman closed 1 year ago

n8layman commented 1 year ago

There were still some bugs with as_of in dbReadTable() when applied to views. This should take care of it.

noamross commented 1 year ago

Two questions:

I realize that my query_as_of() fn probably had an issue with the tryCatch() statement, as on error it didn't stop.

noamross commented 1 year ago

Instead of 

    error = function(e) paste0("'", as_of, "'")

I believe it should be something like

    error = function(e) stop(e, ", some additional text from the query")
n8layman commented 1 year ago

This never got merged but needed to.