runmodel errors with soils other than 'sand'

ecohydro / maize-Toff

Repo for modeling analysis of of maize yield variability and tradeoffs between yield and crop failure.

4 stars 2 forks source link

runmodel errors with soils other than 'sand' #23

Closed noah-de closed 5 years ago

noah-de commented 5 years ago

When running the model with the code of runmodel.py (or similar), there is a value error with 'loam', 'clay' and a few others soil types that I have tried.

The output is helpful:

ValueError: soil field capacity, 0.5057698492600363 is larger than porosity, 0.451

and it even indicates the location of the error:

File "...soil.py", line 190, in __init__ n=self.n

Not sure if this is intentional.

The error message does not appear when using 'sand' as the soil type.

Ntkrell commented 5 years ago

Kelly and I fixed this yesterday, but I forgot to commit it! facepalm. @noah-de I'll work on making the commit now and will reference this issue ;)

noah-de commented 5 years ago

Excellent!