search

ecohydro / maize-Toff

Repo for modeling analysis of of maize yield variability and tradeoffs between yield and crop failure.
4 stars 2 forks source link

Write function for t_sfc #37

Closed Ntkrell closed 4 years ago

Ntkrell commented 4 years ago

Write a Soil function to generate t_sfc for when soil moisture goes above soil field capacity.

Ntkrell commented 4 years ago

Note from Kelly about our issue, which is not an issue..:

Actually, this is already sorted. I figured out the issue that was bothering me, but our code is now correct in as much as it does not contain any ET in the Leakage function. It still "requires" an Emax value, but only because in the absence of any ET, the Leakage loss trends to zero as soil moisture asymptotically approaches sfc, but it will never get there unless Emax is greater than zero. That's why the time_to_sfc function was breaking when Emax was set to zero. We can still run leakage with Emax = 0 though because we are subtracting ET from the soil moisture elsewhere in the model, so we'll never get stuck in the "Xeno's Leakage Paradox" scenario.