Consider moving Soil variables out of soil.py

ecohydro / maize-Toff

Repo for modeling analysis of of maize yield variability and tradeoffs between yield and crop failure.

4 stars 2 forks source link

Consider moving Soil variables out of soil.py #6

Closed noah-de closed 5 years ago

noah-de commented 5 years ago

These variables are hard coded into the soil.py file.

rho = 1000 # density of water in kg/m^3 g = 9.8 # acceleration of gravity in m/s^2 PRECISION = 2 # Number of decimal places of precision in calculations (default is 2)

Perhaps we could move the declaration to a higher level (the model or parameters of the model).

noah-de commented 5 years ago

These are only tangentially related to soil. They are water variables. Not sure what would be best to do...

Ntkrell commented 5 years ago

Move precision to init and make it default. Leave rho and g in soil.py.

noah-de commented 5 years ago

As I went to implement this, it just doesn't seem to buy us anything. (it appears to clutter the interface and documentation).

@Ntkrell If you agree, we should just close #6