ecologylab / BigSemanticsWrapperRepository

Repository of wrappers used by the BigSemantics project.
Apache License 2.0
3 stars 9 forks source link

model field in amazon wrapper needs type fix #7

Closed andru1d closed 11 years ago

andru1d commented 11 years ago

The model field for amazon_product seems to extract URL of a product image.

It's useful, but

1) misnamed

2) mistyped

It should be called image and of type Image.

thanks!

quyin commented 11 years ago

That field is removed. If it refers to the name of the product, there is already ; if it refers to the image, there is already <image>. Its XPath is actually covered by that of <image>.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>