andru1d
commented
11 years ago Sounds like a bug. Are u saying current/past doubles are getting serialized wrong? How will we deal w them?
On Sunday, February 10, 2013, Tom White wrote:
So, there's this pleasant little piece of code here, in DoubleType.java that theoretically lets us parse floaty doubles (1/2, 1.44423/2344.234234, 1.4e10/2.5e120, etc):
public static double rationalToDouble(String rationalString) { String[] stringD = rationalString.split("/", 2); double d0 = Double.parseDouble(stringD[0]); double d1 = Double.parseDouble(stringD[1]);
return d0 / d1; }This gets called by getInstance() if the string is a floaty fraction string:
@Override public Double getInstance(String value, String[] formatStrings, ScalarUnmarshallingContext scalarUnmarshallingContext) { return "null".equalsIgnoreCase(value) ? null : (value != null && value.contains("/")) ? rationalToDouble(value) : new Double(value); }
but doesn't get called by getValue(...)
/* * Convert the parameter to double. /public double getValue(String valueString){ return Double.parseDouble(valueString);}
Which means that it doesn't get called by setValue(...) when we do deserialization:
/** * This is a primitive type, so we set it specially. * * @see simpl.types.ScalarType#setField(Object, Field, String) */ @Override public boolean setField(Object object, Field field, String value) { boolean result = false; try { field.setDouble(object, getValue(value)); result = true; } catch (Exception e) { setFieldError(field, value, e); } return result; }So, the current status quo in our code is to use a semi-sane double format, rather than a weird fractiony format. Should the new scalar types keep the fractiony format, or should we just have a standard double format?
I"m voting that we pick a double format that makes sense / is relatively standard / can be parsed by anyone... the fraction format as is doesn't seem to support that goal.
@andruidk https://github.com/andruidk @amwebbhttps://github.com/amwebb @bilhamil https://github.com/bilhamil @quyin https://github.com/quyin @rhema https://github.com/rhema
— Reply to this email directly or view it on GitHubhttps://github.com/ecologylab/simplJava/issues/61..
andruid kerne, ph.d. director, interface ecology lab associate professor, department of computer science and engineering texas a&m university 979.862.3684 fax college station, tx 77843-3112 http://ecologylab.net
http://facebook.com/ecologylab
Interfaces are the multidimensional border zones through which the interdependent relationships of people, activities, codes, components, and systems are constituted. Interface ecology investigates the dynamic interactions of media, cultures, and disciplines that flow through interfaces.
ghost
bilhamil
So, there's this pleasant little piece of code here, in DoubleType.java that theoretically lets us parse floaty doubles (1/2, 1.44423/2344.234234, 1.4e10/2.5e120, etc):
This gets called by getInstance() if the string is a floaty fraction string:
but doesn't get called by getValue(...)
Which means that it doesn't get called by setValue(...) when we do deserialization:
So, the current status quo in our code is to use a semi-sane double format, rather than a weird fractiony format. Should the new scalar types keep the fractiony format, or should we just have a standard double format?
I"m voting that we pick a double format that makes sense / is relatively standard / can be parsed by anyone... the fraction format as is doesn't seem to support that goal.
@andruidk @amwebb @bilhamil @quyin @rhema