search

ecometrica / django-multisite

Multisite in django — use one Django app to serve multiple domains
BSD 3-Clause "New" or "Revised" License
138 stars 42 forks source link

Bump to Django 1.8 #39

Closed kousu closed 7 years ago

kousu commented 7 years ago

Right now setup.py says Django>=1.6. It still works back there---at least, the tests still pass, though I am not totally confident in them---while Django 1.6 and 1.7's docs warn "This document is for an insecure version of Django that is no longer supported. Please upgrade to a newer release!"

Worse, Django 1.6 and 1.7 are simply not supported on python3. I would like to drop support for these by bumping setup.py to Django>=1.8. Django 1.8 is LTS, which means standardizing on it is a safe bet.

Thoughts?

pauricthelodger commented 7 years ago

I think this makes sense. Maybe a release for #37 with a deprecation warning for 1.6 and 1.7?

kousu commented 7 years ago

Something like this in __init__.py?

if django.VERSION < (1,8):
    warnings.warn("Support for Django under 1.8 will be dropped in version 1.5",
                  DeprecationWarning)
pauricthelodger commented 7 years ago

Aye, that's probably a good spot for it. Maybe a PendingDeprecationWarning instead though? 1.5 makes sense as well, might be something we do a bit after 1.11 LTS is released?

kousu commented 7 years ago

Sure. I can't tell the difference. https://mail.python.org/pipermail/python-dev/2011-October/114199.html suggests they're identical at this point.

pauricthelodger commented 7 years ago

Between the PEP and that thread, I think you're right =)

rebkwok commented 7 years ago

<1.7 support dropped in #45