search

ecometrica / django-multisite

Multisite in django — use one Django app to serve multiple domains
BSD 3-Clause "New" or "Revised" License
138 stars 42 forks source link

fix test to get tmp folder from OS #66

Closed erikvw closed 4 years ago

erikvw commented 4 years ago

test failed if run on macosx because default tmp folder is not /tmp. Consider dropping py3.4

jordiecometrica commented 4 years ago

Is there a reason to not test on Python 3.4? Are you planning on introducing a feature that would break there?

erikvw commented 4 years ago

the tests fail for python 3.4 and seems best to push people up to a higher version. No other reason than that, though. I can undo that if you like. I am personally interested on DJ3.0/py3.8. I see tests pass for DJ2.2/py3.8 already.

jordiecometrica commented 4 years ago

Oh, I didn't see it was already failing. Fair enough.

I don't like forcing people to new versions of the software unless there's a reason for it. I don't like upgrading my software for no good reason, and I don't like doing it to other people either. Nobody is ever happy about mysterious upgrades. But since we have a reason, let's do it.

https://stevelosh.com/blog/2012/04/volatile-software/

jordiecometrica commented 4 years ago

Thanks, I slightly rewrote your commits (no code changes) and pushed them:

https://github.com/ecometrica/django-multisite/commits/639f128