search

ecomfe / echarts-liquidfill

Liquid Fill Chart for Apache ECharts
https://ecomfe.github.io/echarts-liquidfill/example/
BSD 3-Clause "New" or "Revised" License
1.47k stars 620 forks source link

Support ESM like ECharts v5.5 #182

Open kingyue737 opened 4 months ago

kingyue737 commented 4 months ago

Currently, this repo is not maintained.

I also encountered #181 in nuxt, because of the missing of js extension when import module from echarts. Many users cannot use this plugin (#141) which may be due to a dual package hazard (register liquidFill in umd while echarts is esm).

I believe both can be easily solved by migrate to a modern library bundler like unbuild or tsup.

ECharts 5.5 has already changed to default esm package https://github.com/apache/echarts/pull/19513. I think it makes sense to also follow this change in this repo

Is PR welcomed？ I would like to solve this issue.

szhang6 commented 4 months ago

Does this support echarts's version which is "echarts": "^5.5.0" ? It seems does not support for now, right ?

kingyue737 commented 4 months ago

Does this support echarts's version which is "echarts": "^5.5.0" ? It seems does not support for now, right ?

It can be used with v5.5 but may not be out-of-box in some cases. It depends on your environment.