search

ecomfe / fontmin

Minify font seamlessly
http://ecomfe.github.io/fontmin
MIT License
5.62k stars 311 forks source link

fix es modules #96

Open smhg opened 2 years ago

smhg commented 2 years ago

At least on my Node 14.17.6 env the CLI version doesn't work due to ES module-only dependencies (meow) which don't support node's require. I've refactored everything to ES modules. This will break support for older node versions (< 12?), but recent dependency bumps broke that anyway. If you accept the change, it might be good to release this as 0.10 though?

The only (temporary) concession I had to make is the dynamic import of plugins. I've hardcoded them for now, but ideally that should be refactored to await import.

@junmer what do you think?

smhg commented 2 years ago

@junmer it would be really nice if you'd like to release this. The CLI is broken in version 0.9.9. Let me know if I can help.

junmer commented 2 years ago

@mkwiser Please merge the requeset and release a version 1.0.0

smhg commented 2 years ago

@mkwiser @junmer should 1.0.0 be too much of a change, maybe just release this as 0.10.0. That way we have a working CLI again. Thank you!

C0rn3j commented 3 months ago

This now unfortunately conflicts after the 1.0.0 release