search

ecomfe / san-mui

A Set of SAN Components that Implement Google's Material Design
https://ecomfe.github.io/san-mui
MIT License
94 stars 31 forks source link

fix dropdownMenu dynamic items #38

Closed BingBlog closed 7 years ago

BingBlog commented 7 years ago

When use dropdownMenu, found it not support dynamic items. If you change the data items, it throw error. The code just take care of the inited event, and then put the item in the items, but when data items change, the detached event trigger, show remove the item from the data items. I thought it would be more suitable using the 'attached' event instead of 'inited' event.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 44.134% when pulling 71b1ed0c5c8a7a69ab09c12d73d089697ad96fcd on BingBlog:master into 55f367be5f4acb4f79f63c5f0c208108027e32ab on ecomfe:master.