Default ESM package - Githubissues

ecomfe / vue-echarts

Vue.js component for Apache ECharts™.

https://vue-echarts.dev

MIT License

9.43k stars 1.48k forks source link

Default ESM package #762

Closed Shyam-Chen closed 1 month ago

Shyam-Chen commented 4 months ago

Confirmation

[X] I can confirm this is a feature request for the Vue component instead of ECharts itself.

Details

Ref: https://github.com/apache/echarts/pull/19513 (echarts v5.5)

Would you like to follow the updates?

Shyam-Chen commented 4 months ago

If supported, Vitest could do without this line.

# vitest
  resolve: {
-   mainFields: ['module'],
  },

Instead change the require of core.js in /Users/path/to/node_modules/.pnpm/vue-echarts@6.6.9_echarts@5.5.0_vue@3.4.19/node_modules/vue-echarts/dist/index.cjs.min.js to a dynamic import() which is available in all CommonJS modules.
 ❯ Object.<anonymous> node_modules/.pnpm/vue-echarts@6.6.9_echarts@5.5.0_vue@3.4.19/node_modules/vue-echarts/dist/index.cjs.min.js:1:97

Justineo commented 1 month ago

Let's track this at #627.