fix: move events collecting from init to setup

ecomfe / vue-echarts

Vue.js component for Apache ECharts™.

https://vue-echarts.dev

MIT License

9.43k stars 1.48k forks source link

fix: move events collecting from init to setup #779

Closed kingyue737 closed 2 months ago

kingyue737 commented 2 months ago

Sorry, I didn't test it after the commit last night. native: event does not work currently because collecting of native listeners is done in init which is run after render(). This PR moves this code block from init to setup.

Now tested both in Vue 2 and 3.

vercel[bot] commented 2 months ago

@kingyue737 is attempting to deploy a commit to the EFE Team on Vercel.

A member of the Team first needs to authorize it.

Justineo commented 2 months ago

Never mind, I missed that too 😅

Maybe we may eventually need some unit testing...