search

econ-ark / DARKolo

fusion projects combining of Dolo/DolARK and Econ-ARK
4 stars 8 forks source link

Update qModel chimera #26

Closed Mv77 closed 2 years ago

Mv77 commented 2 years ago

This PR updates the qModel chimera to incorporate changes in Dolo's perfect foresight solver

llorracc commented 2 years ago

@albop,

I think this is the third time Mateo has revised the qModel chimera because of changes in Dolo. That makes me more impressed with the pace of your improvements in Dolo -- but also makes me want to ask you how we can "pin" the qModel chimera to a specific release of Dolo so that when mv77 is gone his DolARK/chimera will still work.

llorracc commented 2 years ago

@albop,

I think this is the third time Mateo has revised the qModel chimera because of changes in Dolo. That makes me more impressed with the pace of your improvements in Dolo -- but also makes me want to ask you how we can "pin" the qModel chimera to a specific release of Dolo so that when mv77 is gone his DolARK/chimera will still work.

@albop @Mv77 @MridulS

albop commented 2 years ago

Well, all package managers have a way to specify dependency on a single version. Here I see project mentions specific git commits for dolo and dolang. If you are using it it should work. Another option is to include a compatobility check : just include a Line (assert(dolo.version == (0,4,95,))) or thé specific version you want.

But at the same Time, I'm working on a last architectural / api update. Should bé finished in a few day. This will be the base for 0.5 and the plan is to be backward compatible from there on.

Le dim. 14 nov. 2021 à 04:24, Christopher Llorracc Carroll < @.***> a écrit :

@albop https://github.com/albop,

I think this is the third time Mateo has revised the qModel chimera because of changes in Dolo. That makes me more impressed with the pace of your improvements in Dolo -- but also makes me want to ask you how we can "pin" the qModel chimera to a specific release of Dolo so that when mv77 is gone his DolARK/chimera will still work.

@albop https://github.com/albop @Mv77 https://github.com/Mv77 @MridulS https://github.com/MridulS

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/econ-ark/DARKolo/pull/26#issuecomment-968198556, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACDSKNKAEVKOT7352C6QFDUL4TWXANCNFSM5HFIWTBQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

llorracc commented 2 years ago

@albop, Thanks. This is the umpteenth iteration of the frustrating fact that Jupyter notebooks have no standard for version control of the tools they use. You can do it via the binder folder if you're running on MyBinder, but so far as I've been able to tell there's no "requirements.txt" equivalent on the Jupyter notebook ecosystem. Maybe you should pester Sylvain, who I understand is on the Jupyter board, about this. (The other thing to fix is some standard for citations -- bibtex, biblatex, cite2c, SOMETHING ...)

albop commented 2 years ago

I'll pester him...

I suppose it is currently easier to manage dependencies at the repository level rather than notebook level. Then, there might be a way to automatically create kernels, with an environment containing exactly the right dependencies for each notebook. You would run a command, like make_kernels and create all the kernels dolo_459, dolo_458, ..., then you would have to configure the notebooks to use the relevant kernels. The drawback is, the command must be run before you launch the jupyter, rather than when you open the notebook (like Pluto.jl does). There is probably a way to create a new kernel from a running jupyter instance, that I am not aware of. Actually, I'd be surprised if there wasn't .

On Tue, Nov 16, 2021 at 12:31 AM Christopher Llorracc Carroll < @.***> wrote:

@albop https://github.com/albop, Thanks. This is the umpteenth iteration of the frustrating fact that Jupyter notebooks have no standard for version control of the tools they use. You can do it via the binder folder if you're running on MyBinder, but so far as I've been able to tell there's no "requirements.txt" equivalent on the Jupyter notebook ecosystem. Maybe you should pester Sylvain, who I understand is on the Jupyter board, about this. (The other thing to fix is some standard for citations -- bibtex, biblatex, cite2c, SOMETHING ...)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/econ-ark/DARKolo/pull/26#issuecomment-969436384, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACDSKMJS6FXNKXHPRDBV63UMGJ37ANCNFSM5HFIWTBQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

llorracc commented 2 years ago

A substantial improvement on the current state of affairs would just for there to be an approved and built-in way to check whether all the dependency requirements are met. It's true that we could laboriously put those in by hand at the beginning of every notebook, but then all the notebooks would be ugly and cluttered at the very start, and harder to maintain. We have repeatedly had the problem of people trying to use our notebooks and getting failures that are mysterious to them because they are not very sophisticated. Usually the aggravation would be much less if they just got some message saying "your system does not have the required stuff installed; see the requirements.txt metadata of this notebook for details" or something like that.

On Tue, Nov 16, 2021 at 4:20 AM Pablo Winant @.***> wrote:

I'll pester him...

I suppose it is currently easier to manage dependencies at the repository level rather than notebook level. Then, there might be a way to automatically create kernels, with an environment containing exactly the right dependencies for each notebook. You would run a command, like make_kernels and create all the kernels dolo_459, dolo_458, ..., then you would have to configure the notebooks to use the relevant kernels. The drawback is, the command must be run before you launch the jupyter, rather than when you open the notebook (like Pluto.jl does). There is probably a way to create a new kernel from a running jupyter instance, that I am not aware of. Actually, I'd be surprised if there wasn't .

On Tue, Nov 16, 2021 at 12:31 AM Christopher Llorracc Carroll < @.***> wrote:

@albop https://github.com/albop, Thanks. This is the umpteenth iteration of the frustrating fact that Jupyter notebooks have no standard for version control of the tools they use. You can do it via the binder folder if you're running on MyBinder, but so far as I've been able to tell there's no "requirements.txt" equivalent on the Jupyter notebook ecosystem. Maybe you should pester Sylvain, who I understand is on the Jupyter board, about this. (The other thing to fix is some standard for citations -- bibtex, biblatex, cite2c, SOMETHING ...)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/econ-ark/DARKolo/pull/26#issuecomment-969436384, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AACDSKMJS6FXNKXHPRDBV63UMGJ37ANCNFSM5HFIWTBQ

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/econ-ark/DARKolo/pull/26#issuecomment-970076884, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKCK7YCRQQDKTXC5J42JRTUMIO6NANCNFSM5HFIWTBQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--