search

econ-ark / DemARK

Demonstrations of how to use material in the Econ-ARK
https://econ-ark.github.io/DemARK/
Apache License 2.0
33 stars 93 forks source link

fix LifecycleModelExample #104

Closed MridulS closed 4 years ago

MridulS commented 4 years ago

https://github.com/econ-ark/DemARK/commit/177c09bd387160d06f979c417671b3de18746846 broke the build, qcut should be pd.qcut and savRteByVigtile wasn't initialised.

llorracc commented 4 years ago

Mridul,

Please fix in QuARK-make, not QuARK -- the QuARK content is generated from the QuARK-make/notebooks/LifeCycleModelExample version

On Wed, Mar 4, 2020 at 1:56 PM Mridul Seth notifications@github.com wrote:

177c09b https://github.com/econ-ark/DemARK/commit/177c09bd387160d06f979c417671b3de18746846 broke the build, qcut should be pd.qcut and savRteByVigtile wasn't initialised.

You can view, comment on, or merge this pull request online at:

https://github.com/econ-ark/DemARK/pull/104 Commit Summary

  • fix LifecycleModelExample

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/econ-ark/DemARK/pull/104?email_source=notifications&email_token=AAKCK76PX6ZBEH2AXPSOPOLRFZFZFA5CNFSM4LBGDKPKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ISLTDZQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKCK7334NLN5FYRFSEZD6TRFZFZFANCNFSM4LBGDKPA .

--

MridulS commented 4 years ago

This is the demark repo, is Demark notebooks too generated from Quark-make?

On 04-Mar-2020, at 2:02 PM, Christopher Llorracc Carroll notifications@github.com wrote:

Mridul,

Please fix in QuARK-make, not QuARK -- the QuARK content is generated from the QuARK-make/notebooks/LifeCycleModelExample version

On Wed, Mar 4, 2020 at 1:56 PM Mridul Seth notifications@github.com wrote:

177c09b https://github.com/econ-ark/DemARK/commit/177c09bd387160d06f979c417671b3de18746846 broke the build, qcut should be pd.qcut and savRteByVigtile wasn't initialised.

You can view, comment on, or merge this pull request online at:

https://github.com/econ-ark/DemARK/pull/104 Commit Summary

  • fix LifecycleModelExample

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/econ-ark/DemARK/pull/104?email_source=notifications&email_token=AAKCK76PX6ZBEH2AXPSOPOLRFZFZFA5CNFSM4LBGDKPKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ISLTDZQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKCK7334NLN5FYRFSEZD6TRFZFZFANCNFSM4LBGDKPA .

--

llorracc commented 4 years ago

Yes, both DemARK/notebooks/LifeCycleExample.ipynb and QuARK/notebooks/LifeCycleExample-Problems.ipynb are generated from QuARK-make/notebooks/LifeCycleExample-Problems-And-Solutions.ipynb, but stripping out first the "Solutions" then the "Problems".

But for right now, what I need is QuARK-make and QuARK to work; DemARK can be done later.

On Wed, Mar 4, 2020 at 2:03 PM Mridul Seth notifications@github.com wrote:

This is the demark repo, is Demark notebooks too generated from Quark-make?

On 04-Mar-2020, at 2:02 PM, Christopher Llorracc Carroll < notifications@github.com> wrote:

Mridul,

Please fix in QuARK-make, not QuARK -- the QuARK content is generated from the QuARK-make/notebooks/LifeCycleModelExample version

On Wed, Mar 4, 2020 at 1:56 PM Mridul Seth notifications@github.com wrote:

177c09b < https://github.com/econ-ark/DemARK/commit/177c09bd387160d06f979c417671b3de18746846

broke the build, qcut should be pd.qcut and savRteByVigtile wasn't initialised.

You can view, comment on, or merge this pull request online at:

https://github.com/econ-ark/DemARK/pull/104 Commit Summary

  • fix LifecycleModelExample

File Changes

(169)

(16)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/econ-ark/DemARK/pull/104?email_source=notifications&email_token=AAKCK76PX6ZBEH2AXPSOPOLRFZFZFA5CNFSM4LBGDKPKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ISLTDZQ , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAKCK7334NLN5FYRFSEZD6TRFZFZFANCNFSM4LBGDKPA

.

--

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/econ-ark/DemARK/pull/104?email_source=notifications&email_token=AAKCK7234FRJNPK6YGSP5BTRFZGTVA5CNFSM4LBGDKPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENXXXRQ#issuecomment-594508742, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKCK7453Y4B4VQVNXBQW6DRFZGTVANCNFSM4LBGDKPA .

--

mnwhite commented 4 years ago

Second or third order importance, but it's vigintile, not vigtile. If we abbreviate (as in pctile), it should probably be vgntile. Ventile is also a real word.

MridulS commented 4 years ago

fixed in https://github.com/econ-ark/DemARK/blob/master/notebooks/LifeCycleModelTheoryVsData.ipynb closing this one.