search

econ-ark / DemARK

Demonstrations of how to use material in the Econ-ARK
https://econ-ark.github.io/DemARK/
Apache License 2.0
33 stars 93 forks source link

Fixes to DemARKs to remove dependence on ConsumerParamaters #110

Closed sbenthall closed 4 years ago

sbenthall commented 4 years ago

Addresses #81 and #109

Only failing DemARK currently for this PR is Chinese Growth. It is failing because of the issue raised in #109.

Fixing this will require a change to HARK's constructLognormalIncomeProcessUnemployment function

sbenthall commented 4 years ago

This PR is now ready to merge and fixes the dependencies on ConsumerParameters

llorracc commented 4 years ago

@sbenthall, @MridulS : This seems like perfect first application of the workflow we have discussed elsewhere: We should put the Chinese Growth notebook on a "HARK-commit-#####-breaks-this" branch of DemARK, and worry about fixing it later.

@MridulS, can you execute on this? Merge @sbenthall's PR, then make that branch on DemARK and move Chinese Growth to it? Then as far as I'm concerned we will be ready to make the release and post the blog post.

sbenthall commented 4 years ago

@llorracc I've since fixed Chinese Growth in this PR (today) So it is unnecessary for @MridulS to make the extra branch.

This PR can just be merged, in my view.

MridulS commented 4 years ago

notebooks/PerfForesightCRRA-Approximation.py isn't updated?

sbenthall commented 4 years ago

Good catch. Thank you. I've pushed a commit to fix.