search

econ-ark / DemARK

Demonstrations of how to use material in the Econ-ARK
https://econ-ark.github.io/DemARK/
Apache License 2.0
32 stars 93 forks source link

Chinese Growth fails pytest -- after a long time #163

Closed llorracc closed 3 years ago

llorracc commented 3 years ago

I found this while trying to reinstall the Econ-ARK virtual machine. I guess the reason we haven't noticed it before is that we have somewhere excluded Chinese Growth from our tests, but that exclusion does not get incorporated when the tests are done by the automated

pytest --nbval-lax Chinese-Growth line that gets executed in the

finish scripts.

Is there a better version of the pytest command that would incorporate any future exclusions or caveats we make that allow the automated tests to work?

Chinese-Growth-Fails.txt

MridulS commented 3 years ago

The fail is because of individual cell timeout. The second last cell in the notebook takes 2.5 hours to execute locally on my machine, and successfully creates this plot. Screenshot 2021-09-12 at 14 35 36 You can increase the timeout with something like

pytest --nbval-lax --nbval-cell-timeout=144000
llorracc commented 3 years ago

Ok, I have a theory: when I execoit natively on my machine it takes like 5 min. My guess is that it is massively memory intensive but my machine has 64gb so that’s not a problem. But Linux VM might have 4gb of which only 2 is overhead, so everything gets done on disk.

I guess this tells us that the machines that do the tests on GH are well endowed.

But is there a simple way to exclude it from testing except on gh?

On Sun, Sep 12, 2021 at 8:41 AM Mridul Seth @.***> wrote:

The fail is because of individual cell timeout. The second last cell in the notebook takes 2.5 hours to execute locally on my machine, and successfully creates this plot. [image: Screenshot 2021-09-12 at 14 35 36] https://user-images.githubusercontent.com/5363860/132987944-479cab02-531f-492a-a55f-3440eb3116e2.png You can increase the timeout with something like

pytest --nbval-lax --nbval-cell-timeout=144000

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/econ-ark/DemARK/issues/163#issuecomment-917628817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKCK77U5VRKAOV3ICBAZUTUBSNYJANCNFSM5DNWL4KA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Sent from Gmail Mobile