Keynes Friedman Modigliani edita

econ-ark / DemARK

Demonstrations of how to use material in the Econ-ARK

https://econ-ark.github.io/DemARK/

Apache License 2.0

32 stars 93 forks source link

Keynes Friedman Modigliani edita #164

Closed Mv77 closed 3 years ago

Mv77 commented 3 years ago

@llorracc, here is a PR with the small edits you requested in class (09/13/2021).

Remove a couple of unnecessary references to HARK.
Print numbers using fewer decimal places.

Mv77 commented 3 years ago

The errors are not related to the notebook changed by this PR.

They come from FAILED notebooks/Chinese-Growth.ipynb::Cell 9 FAILED notebooks/DiamondOLG.ipynb::Cell 4

llorracc commented 3 years ago

@MridulS

Odd, with this new PR Chinese-Growth seems to be failing even on GitHub. Plus, there's a new failure, of the OLG notebook. I'll ask @Mv77 to see if he can figure that out. But am puzzled why neither of these was caught by our automatic tests ...

MridulS commented 3 years ago

Yeah, it's the timeout issue with Chinese-Growth but the OLG one is new. The automated tests caught it (I got the notification) I just haven't fixed it yet.