search

econ-ark / DemARK

Demonstrations of how to use material in the Econ-ARK
https://econ-ark.github.io/DemARK/
Apache License 2.0
33 stars 93 forks source link

update demarks pre 0.13 #190

Closed alanlujan91 closed 1 year ago

alanlujan91 commented 1 year ago

@llorracc this is not running automated tests fixed it

llorracc commented 1 year ago

@alanlujan91, what does this PR do?

alanlujan91 commented 1 year ago

Right now, Demarks do not work with master branch of HARK. This should bring them up to date.

Also, I found that the automatic tests for Demarks hadn't run in a few months, so who knows for how long Demarks have been out of sync.

llorracc commented 1 year ago

Took a quick look, but it was hard to find significant changes that should be reviewed among the mass of junk changes (to version numbers, spacing, etc). If it passes the automated tests, I'm OK with merging.

alanlujan91 commented 1 year ago

Part of this PR is syncing and executing all the notebooks/jupytext files to see any changes that have happened with master branch of HARK. Presumably changes should be none/small, but we won't know unless we execute and upload changes to the notebooks.

dedwar65 commented 1 year ago

Thanks, I was able to fetch this PR and then make the appropriate changes in my own notebook.

Will we still meet? Any time this evening should work for me. I am still having the issue of opening the cstwMPC notebook.

Decory

From: alanlujan91 @.> Date: Monday, January 23, 2023 at 4:32 PM To: econ-ark/DemARK @.> Cc: Decory Edwards @.>, Mention @.> Subject: Re: [econ-ark/DemARK] update demarks pre 0.13 (PR #190)

  External Email - Use Caution

@alanlujan91 commented on this pull request.

In notebooks/Micro-and-Macro-Implications-of-Very-Impatient-HHs.pyhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FDemARK%2Fpull%2F190%23discussion_r1084582719&data=05%7C01%7Cdedwar65%40jhu.edu%7C051938f8685d45a2487e08dafd895f00%7C9fa4f438b1e6473b803f86f8aedf0dec%7C0%7C0%7C638101063702848541%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=J5v12w%2Bj0p9UmFviPFUAbczu6WthpVLBEKOd5Y563tg%3D&reserved=0:

@@ -237,7 +256,7 @@ def in_ipynb():

DiscFac_spread = 0.0085 # spread of beta distribution

DiscFac_dstn = (

 Uniform(DiscFac_mean - DiscFac_spread, DiscFac_mean + DiscFac_spread)

@llorracchttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllorracc&data=05%7C01%7Cdedwar65%40jhu.edu%7C051938f8685d45a2487e08dafd895f00%7C9fa4f438b1e6473b803f86f8aedf0dec%7C0%7C0%7C638101063702848541%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=D6rof4p4NaBBYssLyMzuvCA0uQRrkOesNNzdshnb51k%3D&reserved=0 indeed @dedwar65https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdedwar65&data=05%7C01%7Cdedwar65%40jhu.edu%7C051938f8685d45a2487e08dafd895f00%7C9fa4f438b1e6473b803f86f8aedf0dec%7C0%7C0%7C638101063702848541%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NWTGXvPpwfCBE7iG0AWUjICF8%2BPKSFcfNIwKqi8M%2B%2Bc%3D&reserved=0's issue is corrected in this PR

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FDemARK%2Fpull%2F190%23pullrequestreview-1266374582&data=05%7C01%7Cdedwar65%40jhu.edu%7C051938f8685d45a2487e08dafd895f00%7C9fa4f438b1e6473b803f86f8aedf0dec%7C0%7C0%7C638101063702848541%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eX1lApUMf6KX0AcgoXLmT8ifJs45JU6SI3iI01ytm5o%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAR3YDSK2JNTXFCKVQNFRTFDWT32H5ANCNFSM6AAAAAAUBARQNQ&data=05%7C01%7Cdedwar65%40jhu.edu%7C051938f8685d45a2487e08dafd895f00%7C9fa4f438b1e6473b803f86f8aedf0dec%7C0%7C0%7C638101063702848541%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=A6aglhYPF0USp%2BQvhffPLb8cAeY1zd9Q7oy9Uj4sKoE%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

llorracc commented 1 year ago

Merging after @dedwar65 pointed out that without the merge some DemARKs break.