search

econ-ark / DemARK

Demonstrations of how to use material in the Econ-ARK
https://econ-ark.github.io/DemARK/
Apache License 2.0
32 stars 93 forks source link

initial jb/myst #199

Closed alanlujan91 closed 1 year ago

alanlujan91 commented 1 year ago

see https://alanlujan91.github.io/DemARK

alanlujan91 commented 1 year ago

this might be of interest to you as well @camriddell

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

alanlujan91 commented 1 year ago

@camriddell jupyter-books didn't like having ipynb and md files with the same name so I had to separate them into notebooks and markdown directories, will this affect anything else downstream like in the website or in the refactoring work that you are doing?

camriddell commented 1 year ago

This will actually prevent the metadata from being automatically transferred to the website repo. A quick fix will be to swap out the path that the github action workflow searches in:

So you'll need to change this line in DemARK/.github/workflows/transfer-demark-metadata.yml

https://github.com/econ-ark/DemARK/blob/a5fbeae418c5645f859314df42068508f9684594/.github/workflows/transfer-demark-metadata.yml#L14

From notebooks/. to the new folder that contains the .md files.

MridulS commented 1 year ago

This is great @alanlujan91!!! Thanks for this, and yes we need to fixup the metadata markdown files.

We may also should probably figure out a way to keep only the markdown files with the ipynb contents merged into the markdown metadata file :)

Tracking myst markdown is much easier than ipynb

MridulS commented 1 year ago

It works :)

https://econ-ark.github.io/DemARK/