search

econ-ark / DemARK

Demonstrations of how to use material in the Econ-ARK
https://econ-ark.github.io/DemARK/
Apache License 2.0
33 stars 93 forks source link

Micro macro agent pop #201

Closed dedwar65 closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

alanlujan91 commented 1 year ago

@dedwar65 AgentPopulation is now part of HARK, so you should be able to go back and review that this works once you merge upstream changes

dedwar65 commented 1 year ago

@alanlujan91 I think I've requested to merge my changes to the notebook from my "micro-macro-agent-pop" branch into the master branch. I can't tell if this is showing up in this PR though. I suppose if the PR is merged into master on your end, I'd be able to tell if my changes to the notebook made it in.

alanlujan91 commented 1 year ago

@dedwar65 i just merged upstream, can you verify that the notebook has the changes you wanted?

alanlujan91 commented 1 year ago

should be all good now, please review @dedwar65

dedwar65 commented 1 year ago

@alanlujan91 For some reason, I don't see the changes that were made in the "micro-macro-agent-pop" branch. But they show up on my local repo. The changes do show up on NBreview though.