search

econ-ark / DemARK

Demonstrations of how to use material in the Econ-ARK
https://econ-ark.github.io/DemARK/
Apache License 2.0
32 stars 93 forks source link

Fix binder deployment #202

Closed camriddell closed 1 year ago

camriddell commented 1 year ago
  1. There was an error in the specification of the binder/environment.yml format which has been resolved.
  2. Since we are using the environment.yml file, there is no need for the requirements files and these would actually cause the build to redundantly install each package.
camriddell commented 1 year ago

Do note that the PR in its current form breaks CI/CD as that depends on requirements.txt being present, we should figure out the direction we would like to move forward before merging this. @MridulS

Link to mybinder of this fork: https://mybinder.org/v2/gh/camriddell/DemARK/HEAD

llorracc commented 1 year ago

@camriddell @MridulS @sbenthall,

I'm a bit confused about what the next step is on this. Does @MridulS need to review and fix the reasons it fails? Or do you need to do something? Or do I?

MridulS commented 1 year ago

@llorracc I need to review this.

@camriddell Yeah we can safely use .yml for binder. I'll merge this. I'll create a new PR for making CI happy.

MridulS commented 1 year ago

https://mybinder.org/v2/gh/econ-ark/DemARK/master works fine now :) Thanks @camriddell !