Closed mnwhite closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
497de72
) 71.59% compared to head (1549c6b
) 71.59%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bumping version numbers caused a lot of tests to fail. Really not sure what this means.
@mnwhite not your fault, something with numba was failing as of last night
https://github.com/econ-ark/HARK/actions/runs/7734162741
which seems to flow from dependency issues in interpolation.py
Whoops @alanlujan91 , I didn't notice your comment before pushing a test rollback. Because things were working on Tuesday and not working today, I assumed it was the version number change. I guess I'll let things stew for a day or two and see if it resolves itself.
Just checking in on the progress of this …
From: Matthew N. White @.> Date: Thursday, February 1, 2024 at 15:13 To: econ-ark/HARK @.> Cc: Subscribed @.***> Subject: Re: [econ-ark/HARK] Preparation for v0.14.0 release (PR #1377)
Whoops @alanlujan91https://github.com/alanlujan91 , I didn't notice your comment before pushing a test rollback. Because things were working on Tuesday and not working today, I assumed it was the version number change. I guess I'll let things stew for a day or two and see if it resolves itself.
— Reply to this email directly, view it on GitHubhttps://github.com/econ-ark/HARK/pull/1377#issuecomment-1922153758, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKCK76LJI75XRUZTY457M3YRPZN7AVCNFSM6AAAAABCVPZLMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRSGE2TGNZVHA. You are receiving this because you are subscribed to this thread.Message ID: @.***>
@llorracc Something external to HARK has been changed and it's breaking our tests. Alan thinks it's interpolation.py and that we need to remove our usage / dependency on it because it's not being maintained.
tests are starting to pass!
Incredible!
On Wed, Feb 7, 2024, 9:35 AM Alan Lujan @.***> wrote:
tests are starting to pass!
— Reply to this email directly, view it on GitHub https://github.com/econ-ark/HARK/pull/1377#issuecomment-1932179398, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKRAFIYW4NUJACHVCPRZL3YSOGLNAVCNFSM6AAAAABCVPZLMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGE3TSMZZHA . You are receiving this because you were mentioned.Message ID: @.***>
Outstanding check failing has to do with Documentation: @MridulS @AA-Turner help?
@mnwhite this now passes Documentation checks, and will (hopefully) pass all other tests soon
Update CHANGELOG, init, pyproject.