search

econ-ark / HARK

Heterogenous Agents Resources & toolKit
Apache License 2.0
315 stars 195 forks source link

Remove metadata argument for jpg in make_figs #1386

Closed mnwhite closed 3 months ago

mnwhite commented 3 months ago

Metadata argument was not supported for this filetype, was throwing error. CDC wants a minor release for this. I'm going to put in one more annoying behavior fix before I do that.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (85b81ff) 71.59% compared to head (c962d1e) 71.69%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1386 +/- ## ========================================== + Coverage 71.59% 71.69% +0.09% ========================================== Files 84 84 Lines 13933 13939 +6 ========================================== + Hits 9975 9993 +18 + Misses 3958 3946 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mnwhite commented 3 months ago

@alanlujan91 This is a one line bugfix that Chris wanted for #1375 , turning off an illegal argument for jpg in make_figs. He wants a minor release for this (for HAFiscal, I think), so I'm going to do one more little thing (repr behavior for IndShockConsumerType) and then release 0.14.1. Review/merge when you have time.

mnwhite commented 3 months ago

Let me see if I can add a quick test after I grab lunch.