search

econ-ark / HARK

Heterogenous Agents Resources & toolKit
Apache License 2.0
315 stars 195 forks source link

Functional Solvers #1395

Closed alanlujan91 closed 2 weeks ago

alanlujan91 commented 2 months ago

This PR contains some suggestions for @mnwhite's ongoing solver overhaul.

Simple functions that can be re-used within a "family" of models, but should not be expected to "jump" out of their own file.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 53.23383% with 188 lines in your changes are missing coverage. Please review.

Project coverage is 70.56%. Comparing base (1d707c7) to head (fb74f68). Report is 1 commits behind head on master.

Files Patch % Lines
HARK/ConsumptionSaving/ConsPortfolioModel.py 1.81% 162 Missing :warning:
HARK/ConsumptionSaving/ConsIndShockModel.py 89.02% 26 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1395 +/- ## ========================================== - Coverage 71.72% 70.56% -1.16% ========================================== Files 84 84 Lines 13910 14305 +395 ========================================== + Hits 9977 10095 +118 - Misses 3933 4210 +277 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alanlujan91 commented 1 month ago

@mnwhite updated MPCmaxUnc to apply to MPC_for_interpolation and MPCmaxNow to be the effective mpc max

alanlujan91 commented 2 weeks ago

@mnwhite added docstrings and merging as discussed