search

econ-ark / HARK

Heterogenous Agents Resources & toolKit
Apache License 2.0
315 stars 195 forks source link

Simplify pre-commit usage #1396

Closed MridulS closed 2 months ago

MridulS commented 2 months ago

This move the pre-commit config to use the inbuilt ruff formatter and ruff for linter all over HARK.

llorracc commented 2 months ago

@MridulS,

Sounds like a good idea, but tests are failing ...

alanlujan91 commented 2 months ago

A quick look seems to indicate the failing tests are unrelated to @MridulS's changes. I'll take a look later today

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 71.71%. Comparing base (df9b60c) to head (bca2586).

Files Patch % Lines
HARK/ConsumptionSaving/ConsRiskyContribModel.py 0.00% 2 Missing :warning:
HARK/tests/OpenCLtest.py 0.00% 1 Missing :warning:
HARK/utilities.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1396 +/- ## ========================================== - Coverage 71.72% 71.71% -0.01% ========================================== Files 84 83 -1 Lines 13910 13903 -7 ========================================== - Hits 9977 9971 -6 + Misses 3933 3932 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mnwhite commented 2 months ago

Merging this now. The 4 lines alleged by codecov not to be covered don't appear to actually exist-- it won't show me any uncovered changes.