search

econ-ark / HARK

Heterogenous Agents Resources & toolKit
Apache License 2.0
315 stars 195 forks source link

Counterpart example notebooks for bequests with portfolio choice #1398

Closed dedwar65 closed 1 month ago

dedwar65 commented 2 months ago

Pull request is nearly complete. Some small discrepancies need to be sorted. Lastly, Something regarding the optimal shares in the model should be added.

alanlujan91 commented 1 month ago

@dedwar65 is this done? can you resolve conflicts?

dedwar65 commented 1 month ago

If you recall, in the HARK meeting before last you told me to make a pull request with the changes to the example notebooks. The notebooks ran, but there is a final discrepancy that needs to be resolved. It shouldn’t be causing anything to break though.

I am not too sure how to resolve the conflict on my end but I will look into it.

From: Alan Lujan @.> Date: Friday, April 5, 2024 at 2:44 PM To: econ-ark/HARK @.> Cc: Decory Edwards @.>, Mention @.> Subject: Re: [econ-ark/HARK] Counterpart example notebooks for bequests with portfolio choice (PR #1398)

  External Email - Use Caution

@dedwar65https://github.com/dedwar65 is this done? can you resolve conflicts?

— Reply to this email directly, view it on GitHubhttps://github.com/econ-ark/HARK/pull/1398#issuecomment-2040428276, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR3YDSM5UJZGPZN2NINKHBLY33WIDAVCNFSM6AAAAABEXBN5U6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGQZDQMRXGY. You are receiving this because you were mentioned.Message ID: @.***>

alanlujan91 commented 1 month ago

hoping this works now and that I didn't break anything else

@dedwar65 if this passes all tests, can you review the notebooks and add some descriptive narrative to the examples?