search

econ-ark / HARK

Heterogenous Agents Resources & toolKit
Apache License 2.0
315 stars 195 forks source link

Sequence Space Jacobian Type #1416

Open alanlujan91 opened 3 weeks ago

alanlujan91 commented 3 weeks ago

Integrating @wdu9's work on SSJ.

The results are very wrong... which is probably due to my lack of experience with SSJ

Would appreciate help from @wdu9 and @Mv77

MridulS commented 3 weeks ago

I see this in the runs:

FAILED HARK/ConsumptionSaving/tests/test_SequenceSpaceJacobianType.py::test_Transition_Matrix_Methods::test_calc_tran_matrix - AttributeError: 'SequenceSpaceJacobianType' object has no attribute 'taxrate'. Did you mean: 'tax_rate'?
FAILED HARK/ConsumptionSaving/tests/test_SequenceSpaceJacobianType.py::test_Jacobian_methods::test_calc_jacobian - AttributeError: 'SequenceSpaceJacobianType' object has no attribute 'taxrate'. Did you mean: 'tax_rate'?
Mv77 commented 3 weeks ago

A minor comment is that, since SSJ is a method and not a model, I don't think that SSJType is appropriate. Maybe NewKeynesianType?