search

econ-ark / HARK

Heterogenous Agents Resources & toolKit
Apache License 2.0
320 stars 195 forks source link

Sequence Space Jacobian Notebook #1435

Closed alanlujan91 closed 3 weeks ago

alanlujan91 commented 1 month ago

There are currently two PRs attempting to do the same thing.

One issue with #1424 is that the examples/HARK-SSJ-Example/ConsIndShockModel_HANK.py file is mostly a copy of ConsIndShockModel.py with a few things changed. The approach I took in #1416 was to remove everything related to ssj and move it to its own file, while inheriting from ConsIndShockModel without repeating chunks of code.

As far as I can tell, neither approaches work correctly yet, so I'm wondering if the authors could get together and figure out the best approach to get this through the finish line.

@wdu9 @AMonninger @kennetheva

mnwhite commented 1 month ago

I think some of the issue is due to a small change I had to put into calc_jacobian to make it not break other things. I suspect the fix for this code is 1-2 lines to adjust to the change.

On Tue, May 28, 2024, 11:08 AM Alan Lujan @.***> wrote:

There are currently two PRs attempting to do the same thing.

One issue with #1424 https://github.com/econ-ark/HARK/pull/1424 is that the examples/HARK-SSJ-Example/ConsIndShockModel_HANK.py file is mostly a copy of ConsIndShockModel.py with a few things changed. The approach I took in #1416 https://github.com/econ-ark/HARK/pull/1416 was to remove everything related to ssj and move it to its own file, while inheriting from ConsIndShockModel without repeating chunks of code.

As far as I can tell, neither approaches work correctly yet, so I'm wondering if the authors could get together and figure out the best approach to get this through the finish line.

@wdu9 https://github.com/wdu9 @AMonninger https://github.com/AMonninger @kennetheva https://github.com/kennetheva

— Reply to this email directly, view it on GitHub https://github.com/econ-ark/HARK/issues/1435, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKRAFKFI2B3SD2WEQRXT5TZESMYTAVCNFSM6AAAAABINEOI2WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDCMZSGQ2DAOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mnwhite commented 3 weeks ago

The notebook has now been merged into HARK and is working properly; it's currently being expanded and improved. Closing.