Remove employment accounting lines

Mv77 commented 4 months ago

Two lines that were added to the income process of consindshock for cstwMPC are now causing trouble. See https://github.com/econ-ark/HARK/issues/984 and https://github.com/econ-ark/HARK/issues/1182.

This PR removes those lines. This does not break anything within HARK itself.

[x] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[x] Updated documentation of features that add new functionality.
[x] Update CHANGELOG.md with major/minor changes.

Mv77 commented 4 months ago

I imagine this might break the compatibility of the cstwMPC REMARK with the current version of HARK. However, it is also my understanding that REMARKs are now properly pinned to a specific version of HARK, so this should not be an issue.

mnwhite commented 4 months ago

Mateo isn't the developer we deserve, but he's the developer we need.

On Sat, Jul 13, 2024 at 10:21 AM Mateo Velásquez-Giraldo < @.***> wrote:

@Mv77 https://github.com/Mv77 requested your review on: #1473 https://github.com/econ-ark/HARK/pull/1473 Remove employment accounting lines.

— Reply to this email directly, view it on GitHub https://github.com/econ-ark/HARK/pull/1473#event-13495570658, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKRAFOFUE3JMP6253AKCG3ZMEZX5AVCNFSM6AAAAABK2J7Q7WVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGQ4TKNJXGA3DKOA . You are receiving this because your review was requested.Message ID: @.***>

Mv77 commented 4 months ago

Hah thanks. I take that as your approval and so I'll merge this in.

econ-ark / HARK

Remove employment accounting lines #1473